Introduce decorators for index names

massiveart / MassiveSearchBundle

MIT License

68 stars 24 forks source link

Introduce decorators for index names #68

Closed danrot closed 8 years ago

danrot commented 8 years ago

This PR adds the ability to use decorators for adapting the index name. The current LocalizationStrategy is converted to a decorator, and another one for prefixing the installation is also added.

tasks:

[x] test coverage
[ ] gather feedback for my changes
[x] add decorator for prefixing

informations:

q	a
Fixed tickets	fixes https://github.com/sulu-io/sulu/issues/1798
BC breaks	LocalizationStrategyInterface is removed
Documentation PR	TODO

wachterjohannes commented 8 years ago

@danrot missing doc file

wachterjohannes commented 8 years ago

@danrot copy upgrade to sulu and fix style!

danrot commented 8 years ago

I'll just push the upgrade after this is merged, there is no separate PR for sulu/sulu yet, and I don't want to create it just because of the upgrade file.

danrot commented 8 years ago

@wachterjohannes This PR should be ready now.

danrot commented 8 years ago

Ok, it's not, have to update the documentation first.

danrot commented 8 years ago

@wachterjohannes Now it is ready

danrot commented 8 years ago

Added the upgrade in https://github.com/sulu-io/sulu/commit/3d8972b6785aec16a7fd39d90ae2c8c8e97d2969