search

massiveart / husky

Other
19 stars 12 forks source link

Issue when using addPlugin method of ckeditor extension #767

Closed sarramegnag closed 7 years ago

sarramegnag commented 7 years ago

Fix issue when using addPlugin method of ckeditor extension without passing a plugin parameter.

Related issue : https://github.com/sulu/sulu/issues/3313

alexander-schranz commented 7 years ago

@SarramegnaG you need to create the build locally for this you need npm and grunt.

When I remember it correctly when you then run following commands:

npm install
grunt build

The dist/husky.js and dist/husky.min.js should be builded.

See: https://github.com/massiveart/husky#how-to-contribute-like-a-boss

sarramegnag commented 7 years ago

Sorry I thought the part with all the command lines was to install, not to contribute.

I updated with dist files. It should be ok now :)

wachterjohannes commented 7 years ago

@SarramegnaG sorry for the long delay (: can you also add a line to CHANGELOG.md

wachterjohannes commented 7 years ago

replaced by https://github.com/massiveart/husky/pull/770