search

massivefermion / blah

fake data generation for gleam
https://hex.pm/packages/blah
Apache License 2.0
16 stars 4 forks source link

sort and remove duplicates on constants of dummy data #1

Closed inoas closed 2 years ago

inoas commented 2 years ago

What I did:

  1. open the files with constants
  2. copy constants to another file, split into lines based on ,
  3. sort ascending
  4. remove duplicate lines
  5. copy back into gleam file and save
inoas commented 2 years ago

There are no unit tests so I couldn't test but the gleam compiler did not complain in the vscode lsp when I saved the gleam files, at least.

inoas commented 2 years ago

The diffs make more sense comparing via difftastic.

inoas commented 2 years ago

... and I did this because when browsing I noticed Europe/Berlin was there twice as a time zone.

massivefermion commented 2 years ago

Thanks a lot. I tested a few functions and everything seems to be fine. I'll gradually add some tests though! I should say that this is the first time anyone has sent a PR to any of my packages, so I really appreciate it! :)