massivefermion / blah

fake data generation for gleam
https://hex.pm/packages/blah
Apache License 2.0
16 stars 4 forks source link

Finance translation #2

Open PascalLeMerrer opened 7 months ago

PascalLeMerrer commented 7 months ago

Hello

I'm preparing a French localization —I'll submit a PR this week.

The last part I have to prepare is the Finance one. The en/finance.gleam file contains an array of tuples. The first item of each tuple is a string, which most of the time starts with a country name, followed by the name of the currency for this country.

massivefermion commented 7 months ago

Hello That's great, looking forward to your PR! yeah, apparently I wasn't careful about the currencies. I do think it's better to have the name of the countries instead of just having Europe. Thanks for the issue

PascalLeMerrer commented 7 months ago

It's not what I was saying... I suggest you to read the issue again.

You can't put the name of the countries in this specific case, as 20 countries are using the Euro as a currency. In French we call them "la zone euro" which means "the euro zone" ; and the name of the currency is "euro" too. So the string should be something like "euro zone Euro" in English or "zone euro Euro" in French.

massivefermion commented 7 months ago

Sorry, I was really tired when I read that. Just to make sure I'm not misreading things again, what you're suggesting is:

Both of these make sense to me.

PascalLeMerrer commented 7 months ago

having a better name for Europe, your suggestion being "Euro Zone"

I just checked and in English the right term is Eurozone; we could use that indeed.

Not having the name of the country and the currency both in the same string

Exactly.