search

masslight / ottehr

Modular, Production-Ready, Open-Source EHR
https://ottehr.com
Other
122 stars 139 forks source link

Fix build error #255

Closed GiladSchneider closed 1 month ago

GiladSchneider commented 1 month ago

Our builds were failing because of: ERR_PNPM_FETCH_404  GET https://registry.npmjs.org/ottehr-utils[:](https://registry.npmjs.org/ottehr-utils:) Not Found - 404

we merged https://github.com/masslight/ottehr/pull/256 as a temporary solve, but need to figure out why this is happening and push a real solution.

The original problem was introduced in https://github.com/masslight/ottehr/commit/a164bcaac72e98c5383437077d0ef227ab7c9412#diff-571d7c5f092e15732ebc9c3ad10699a61949858650a6e4b8303ad1fb4b26488c

saewitz commented 1 month ago

We have had this issue for a few weeks. It started with this PR I think: https://github.com/masslight/ottehr/pull/234 I have undone the changes for each file from that PR and it did not resolve the issue. It is likely an issue with our pnpm setup. We have some local packages, and it's trying to find them on npm registry but we haven't published these packages on it. This issue was partially resolved in #256 so it works locally, but we are still getting the error on GitHub Actions.

GiladSchneider commented 1 month ago

Tested and pnpm i is working, along with pnpm build