search

masslight / ottehr

Modular, Production-Ready, Open-Source EHR
https://ottehr.com
Other
114 stars 118 forks source link

Use plurals only for numbers other than one #99

Closed OmarZubaidi closed 2 months ago

OmarZubaidi commented 7 months ago
Screenshot 2023-12-01 at 14 43 59
Mtimpson commented 7 months ago

Could you add some additional details/explanation to this ticket - I'm not sure what's being referenced here. What needs to be plural in the screenshot?

Thanks! @OmarZubaidi

OmarZubaidi commented 7 months ago

If something starts with one it should be singular, and if it starts with zero or more than one, it should be plural. So, in this case, it should say one hour or two hours.

ncgreene commented 7 months ago

Seems like something we could come back to later, agreed?

OmarZubaidi commented 7 months ago

Definitely a QOL update rather than something MVP worthy

Mtimpson commented 7 months ago

This was straight forward so I went ahead and made the corrections/changes even though it purely QOL: 99-use-plurals-only-for-numbers-other-than-one

Complete & ready for testing once approved and merged.

Thank you both @ncgreene & @OmarZubaidi