Open mirco0 opened 1 year ago
@mirco0 Hello! Thank you for your contribution to this project. I have checked your code and I'm not sure about MediaPlayer instance inside view. How it will work if the user populate list (recycler view) of waveforms? 🤔
Maybe it will be better to provide an API like attach or set player. In this case, the user can provide an external player. This approach seems more flexible IMHO
@massoudss
@massoudss Hello! Thank you for telling me about the issue in my code. I think your solution is a good idea, I'll update and fix my code when possible
This pull request adds a new view
waveformTimeline
. This new view includes:Todo list
waveGap
andwaveWidth
greater than minimal values