search

masspastore / overlapping

Estimation of Overlapping in Empirical Distributions.
GNU General Public License v3.0
8 stars 3 forks source link

put paper under paper, do linting, add roxygen comments for overlap function #6

Closed soodoku closed 6 years ago

soodoku commented 6 years ago

Hey man,

Just doing some basic cleaning to help out here.

You need to describe each function --- minimum is what parameters of the function + output of the function

I didn't understand why you have a bunch of attach etc. for ggplot. These are automatically attached if you put them in description.

masspastore commented 6 years ago

Thanks @soodoku for your suggestions

soodoku commented 6 years ago

@masspastore: If you approve of the changes, one way to merge the changes in is to do a squash and merge. Right now the changes haven't been merged. And this is just a fyi. Whether or not you want to merge depends on you.