search

master-co / css

The CSS Language and Framework
https://css.master.co
MIT License
1.82k stars 41 forks source link

💖 New `render()` function throwing errors in SvelteKit #310

Closed oskar-gmerek closed 1 year ago

oskar-gmerek commented 1 year ago

Current

After updating from:

const mastercss = (async ({ event, resolve }) => {
    return await resolve(event, {
        transformPageChunk: ({ html }) => return renderHTML(html, config);
    });
}) satisfies Handle;

to:

const mastercss = (async ({ event, resolve }) => {
    return await resolve(event, {
        transformPageChunk: ({ html }) => render(html, config).html
    });
}) satisfies Handle;

SvelteKit starts throwing errors in console (every time the SvelteKit server receives a request, so a lot of them):

Removing comments in transformPageChunk can break Svelte's hydration

Expected

Not throwing errors nor makes possibility to break Svelte's hydration.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.0.0-beta.203 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version 2.0.0-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: