master-co / css

The CSS Language and Framework
https://css.master.co
MIT License
1.75k stars 42 forks source link

🐞 normal.css max-width causes many problems #318

Closed fightingdreamer closed 6 months ago

fightingdreamer commented 6 months ago

Description

Introduced in a8171cfbbc95cb03b5be47bb7f9f09a69e90a47a max-width: 100%; have very big impact on cases when elements are expected to overflow.

Maybe such rules can be put in new package called master-css-sensible-defaults.css?

Reproduction

No response

System Informations

No response

1aron commented 6 months ago

In practice, img and video may be expected to be limited to a maximum width of 100%. So, we prefer that you batch cancel the full width of the target elements through the selector:

<div class="max-w:none_:where(img)">
fightingdreamer commented 6 months ago

I was not aware of that selector in master-css, big thanks!

1aron commented 6 months ago

@fightingdreamer I've improved the usage instructions. https://beta.css.master.co/docs/global-styles#responsive-friendly-media-elements

Xnapper-2023-12-22-15 47 23
fightingdreamer commented 6 months ago

Great!

The lack of documentation is an issue when convincing colleagues to switch from tailwind-css / uno-css.

1aron commented 6 months ago

@fightingdreamer This is undeniable, and we will improve all documents in RC. Previously, we were still making breakthroughs in R&D and architecture, and the documents have not yet been finalized.

Thx for your support!