search

master-co / css

The CSS Language and Framework
https://css.master.co
MIT License
1.82k stars 41 forks source link

🐞 V2 Inconsistent Behavior With Angular #357

Closed HealMah closed 5 months ago

HealMah commented 5 months ago

Description

Having installed the framework as documented for Angular (18) in a monorepo, some core features (built-in css classes) are not working consistently. Notable, the bg:color. See the attached screenshots in Reproduction Section.

Reproduction

Please see the provided screenshots Screenshot_20240609_230718 Screenshot_20240609_230811 Screenshot_20240609_230850 Screenshot_20240609_230919

1aron commented 5 months ago

@HealMah There are no intermediate values ​​for v2 colors, see https://rc.css.master.co/reference/colors. Additionally, the bg:red fg:yellow defaults rely on the light/dark classes on <html class="light">. https://rc.css.master.co/reference/base-colors

image

HealMah commented 5 months ago

@HealMah There are no intermediate values ​​for v2 colors, see https://rc.css.master.co/reference/colors. Additionally, the bg:red fg:yellow defaults currently rely on the light/dark classes on <html>. https://rc.css.master.co/reference/base-colors

image

Ooops, obviously I am not good with this latest version yet. But, "No intermediate values"???. Anyways, no doubt, this is "Master Css". IT'S GREAT, so kudos to you and your team.

HealMah commented 5 months ago

Please may I know why one of the following is working but not the other? And this is with classs 'light' on the html element - please see the screenshots. Screenshot_20240610_215640 Screenshot_20240610_215713

Besides, I don't know the real reason behind mandating assigning the theme class ('light', 'black', or otherwise) for colors to work properly, BUT - it seems counter-productive, sorry to say. WHAT IF I DON'T WANT to use this framework for managing themes? Color 'red' should be red, what bg is and isn't shouldn't be a burden on the framework - the developer should know enough about his color system! I think this is how the v1 works.

The moment there is not a theme class on any parent, MOST colors go blank - THAT'S WEIRD! Or am I missing something? I hope you understand my concerns, PLEASE do help enlighten us SIR!

1aron commented 5 months ago

@HealMah In v2, only red-5 red-10 red-20 red-30 ... are available. We value the real experience of developers and have indeed re-evaluated the solution of not driving color through html.light html.dark.

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 2.0.0-rc.42 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

1aron commented 5 months ago

@HealMah As of v2.0.0-rc.42 it is no longer necessary to add <html class="light"> to drive colors.