master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.4k stars 147 forks source link

Unclear unit for --extra-split option #706

Open louie-github opened 1 year ago

louie-github commented 1 year ago

The -x, --extra-split option is not clear about which unit it uses. Does it use seconds? Frames?

Maximum scene length

When a scenecut is found whose distance to the previous scenecut is greater than the value specified by this option, one or more extra splits (scenecuts) are added. Set this option to 0 to disable adding extra splits.

It might be obvious to some that it's frames, but, it's a bit ambiguous as-is.

I suggest making that unit clearer. Some new versions I thought of (with additions highlighted) are:

Maximum scene length

When a scenecut is found whose distance in frames to the previous scenecut is greater than the value specified by this option, one or more extra splits (scenecuts) are added. Set this option to 0 to disable adding extra splits.

or, alternatively:

Maximum scene length

When a scenecut is found whose distance to the previous scenecut is greater than the number of frames specified by this option, one or more extra splits (scenecuts) are added. Set this option to 0 to disable adding extra splits.

If you have any better ways of wording this, of course, please use that.

Thank you for your time!