search

master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.46k stars 151 forks source link

Fix building on some non-x64 platforms #717

Closed shssoichiro closed 1 year ago

shssoichiro commented 1 year ago

I'm going to note that this is untested because I don't have a machine to test it on. Platforms I'm aware of that are producing the issue are aarch64 and Windows+msys. If someone could pull this and give it a build to verify, that would be great.

shssoichiro commented 1 year ago

I've asked multiple people in Discord who have reported this issue to please test it and it seems nobody is going to. Let's just merge it and hope it works. Essentially I reverted a set of changes in the upstream ffmpeg crate that fixed some clippy lints, but those clippy lints were removing necessary casts on some platforms. See https://github.com/shssoichiro/ffmpeg-the-third/commit/ed9703b739fb86d4ed20b40d9d9ddda7163a812c