search

master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.46k stars 151 forks source link

Action: Test target-quality is working correctly. #743

Closed luigi311 closed 1 year ago

luigi311 commented 1 year ago

Addresses #719

Adds a test to make sure target-quality is actually working by encoding at a target of 95 and 80 and then comparing to make sure the 95 version is bigger than the 80. In the event that it does fail it will also cat the log files to make sure so the developers can see what is happening and adjust the test or fix the issue if there is one.

In this case we can see that there is no vmaf comparison happening and av1an is just doing a normal chunk encoding thus the two 95 and 80 are exactly the same size and is validated by the logs.

master-of-zen commented 1 year ago

That's a good test 👍🏽

master-of-zen commented 1 year ago

UNFORTUNATELY, we can't merge it because it doesn't pass tests 🤓