master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.4k stars 147 forks source link

[BISECTED] Accsess violation on vapoursynth input #773

Closed Quackdoc closed 11 months ago

Quackdoc commented 11 months ago

commit 330e6a29396edb6ea0c87c721e43721ed9ada9b3 (bisected and manually tested the previous commit to verify it worked) introduced a regression for one user that causes av1an to be killed by svchost due to accsess violation we narrowed it down to LN 910 let frame_rate = self.input.frame_rate().unwrap(); by manually adding a before and after check to this.

av1an isnt providing a backtrace even when compiled we needed to use GFLAGS from windbg since the process was silently exiting.

it regulairly manages to go through about at least 200 loops before dying. the footage is CFR. tested enforcing it inside of the VS script too with no luck.

still trying to help a user debug it but this is what we have for now, I haven't been able to replicate the issue myself even with the same footage. verified the install environment is the same with VS and same av1an binary.

EDIT: I checked the windows dumps and it looks like this is actually an intermittent vapoursynth crash on the users end. more testing will be done but if nothing else shows up in the next few days ill end up closing this ticket as a VS issue

Quackdoc commented 11 months ago

Another user is reporting this crashes during the check framerate step and likewise VS itself is segfaulting on windows