search

master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.4k stars 147 forks source link

Using --target-quality forces --vmaf #790

Closed luigi311 closed 2 months ago

luigi311 commented 7 months ago

Seems like whenever you use target-quality it forces the vmaf that happens after encoding finishes. You can see the : : VMAF Run line at end after the encode has finished when i never added in the --vmaf flag.

carif commented 3 months ago

Seems like this part of the code is the problem: https://github.com/master-of-zen/Av1an/blob/db278e27729ddc2f99b358d72a0d5cb2a93b93b8/av1an-core/src/context.rs#L349-L375

Assuming I understand it correctly, someone put the code of --vmaf and --target-quality under the setting for --target-quality .