Mention silent truncation of probing_rate>4

master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding

GNU General Public License v3.0

1.4k stars 147 forks source link

Mention silent truncation of probing_rate>4 #803

Open t-nil opened 5 months ago

t-nil commented 5 months ago

In target_quality.rs, fn adapt_probing_rate() is used to truncate the probing rate. This is not mentioned in the parameter description.

FreezyLemon commented 5 months ago

This is surprising behaviour, and I did not know it worked like that. It might be even better to max it out at 4 and give a runtime warning..

shssoichiro commented 5 months ago

I second the above suggestion, I'd rather have less surprising behavior for the end user if possible. If it's possible to update this PR to make that change, it would be appreciated.

t-nil commented 1 month ago

> ~/.cache/cargo_target/debug/av1an --probing-rate 5
error: invalid value '5' for '--probing-rate <PROBING_RATE>': 5 is not in 1..=4

For more information, try '--help'.

Should be mergable now