master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.4k stars 147 forks source link

Fix vmaf flag check with target-quality #823

Closed luigi311 closed 2 months ago

luigi311 commented 2 months ago

Fixes issue where vmaf plot was always ran if target-quality was set, this does not allow you to run vmaf plot without target-quality as it seems like vmaf plot was designed around target-quality at some point so --vmaf without --target-quality will do nothing. Decoupling the two seems like it will be a lot of work so I am adding this for now as it atleast closes #790 and the decoupling can happen later

master-of-zen commented 2 months ago

👍🏽