search

master-of-zen / Av1an

Cross-platform command-line AV1 / VP9 / HEVC / H264 encoding framework with per scene quality encoding
GNU General Public License v3.0
1.4k stars 147 forks source link

SVT-AV1-PSY --target-quality support? #837

Open NZDivinity opened 1 month ago

NZDivinity commented 1 month ago

Currently the --target-quality parameter for Av1an does not work with the PSY fork of SVT-AV1 - errors out. --target-quality does work when it is used in conjunction with --probe-slow.

The same Av1an command (without probe slow) works fine with regular SVT-AV1.

Any chance this parameter could be supported by SVT-AV1-PSY?

Edit : My bad, was a bit quick posting this issue. see Trix's reply below with context on possible cause.

trixoniisama commented 1 month ago

You could have given some additional context since we've started to troubleshoot it on the AV1 discord server...

It is likely that SVT-AV1-PSY is not recognized as modern SVT-AV1 and as such outdated parameters are fed to the encoder which leads to crashes.

The usefulness of keeping compatibility with incredibly old SVT-AV1 versions isn't evident to me. I think that to avoid further issues like this in the future, it would be better to remove support for these ancient versions. It will avoid false positives with potential forks and newer version numbers.

gitoss commented 2 weeks ago

Currently the --target-quality parameter for Av1an does not work with the PSY fork of SVT-AV1 - errors out.

SVT-AV1-PSY has been updated to current SVT-AV1 and is working just fine, so this issue can be closed.