search

master-of-zen / BOPUS

Bitrate Optimization for OPUS
30 stars 6 forks source link

Run `cargo fmt`, fix clippy warnings, simplify some code #3

Closed redzic closed 3 years ago

redzic commented 3 years ago

Also removed #![feature(type_ascription)] to compile with stable rust, and also to fix false rust-analyzer warnings. Changed version of num_cpus to the latest version (1.13.0)

master-of-zen commented 3 years ago

@redzic Thank you a lot. It's my first rust project :smile:

master-of-zen commented 3 years ago

@redzic :1st_place_medal:

redzic commented 3 years ago

haha no problem! Also, you can simplify the CLI parsing logic a lot if you use structopt instead of clap (I noticed a lot of .unwrap() calls with getting some CLI args -- if you use structopt it will handle all that for you and will display nice error message). structopt uses clap as its dependency, so no issues there.

I'll probably make a PR for that as well