master117 / MagicMirror-FootballLeagues

A live viewer for recent soccer results and league tables. Outdated!
GNU General Public License v3.0
7 stars 5 forks source link

activeLeagueFixtures is undefined #1

Closed prysme01 closed 6 years ago

prysme01 commented 6 years ago

Hello I've just installed your module, but it does not work, with or without apikey

here is my config file { module: 'MagicMirror-FootballLeagues', position: 'top_right', header: 'Football Adrien', config: { leagues: [450], showNames: true, displayTime: 60 1000 2, showTables: true, apiKey: 'xxxxxxx' } },

master117 commented 6 years ago

Hello,

that is sad to hear.

I just installed MagicMirror from Scratch, pulled this repo and used the config you provided. And it works for me. https://i.imgur.com/0KYmCEN.png

  1. You wrote: activeLeagueFixtures is undefined as the title,

could you give me more information on that? Where does that error appear, in the console, in browser? Does it repeat? Is there line numbers? activeLeagueFixtures are the fixtures of the selected league and should not be undefined at any moment.

  1. I added a bit more additional error logging to the code, so it would be great if you could update.

  2. I assume all the files from the repo are where they should be?

Greetings, Johannes

master117 commented 6 years ago

I think I have found the bug and fixed it, it was a racing condition. Please update to the newest version and reopen this issue if the problem still exists.

prysme01 commented 6 years ago

Thanks for your time , now it's working fine. Maybe because my ISP speed sucks, I often run into hidden bugs :) Anyway have a good week end !

master117 commented 6 years ago

Glad this fixed your issue. Please let me know if you encounter any other bugs.