search

masterT / bandcamp-scraper

A scraper for https://bandcamp.com
MIT License
193 stars 35 forks source link

fixed the bug for parseAlbumRawInfo #17

Closed glenvollmer closed 7 years ago

glenvollmer commented 7 years ago

The object "TralbumData" that "parseAlbumRawInfo" scrapes for was updated by bandcamp and it seems that the property "cfg_territory_support_on:" was added to the object causing the validation to fail and return null. I updated the regex at line 251 in htmlParser.js to check for the property "cfg_territory_support_on:" instead of "is_band_member:" and it seems to have fixed the error.

masterT commented 7 years ago

It looks like the build still failing. 😕

glenvollmer commented 7 years ago

I'll keep playing around with it

masterT commented 7 years ago

You gave up?

glenvollmer commented 7 years ago

It looks like the build is no longer failing, and I am able to return the raw album info when I run the scraper. Also the changes I made no longer apply to the TralbumData object that's being scrapped. I think bandcamp updated the contents of the object again.