search

masterT / bandcamp-scraper

A scraper for https://bandcamp.com
MIT License
193 stars 35 forks source link

Feature request: Get purchasing fans from album URL #6

Open mrdavemorgan opened 7 years ago

mrdavemorgan commented 7 years ago

Readme says "Contribution is welcome! Open an issue first." So ...

I'm doing some work to retrieve fans who have purchased an album. If this feature is useful I can do a pull request. Thanks.

masterT commented 7 years ago

Hi @mrdavemorgan,

Yes I agree this can be useful, PR welcome! 😃

masterT commented 7 years ago

I suggest you to return the additional info in the getAlbumInfo. You'll also need to update the JSON schema.

mrdavemorgan commented 7 years ago

The fan list returned can be rather large (see this example). If you don't think that's too much, then I'll insert it into the album info as suggested.

masterT commented 7 years ago

Well it's huge! It'll be ok if it has its own function!

masterT commented 6 years ago

@mrdavemorgan What's up with this feature?

mrdavemorgan commented 6 years ago

Had a proof of concept, but nothing clean enough to submit. Got sidetracked with some other projects, but I'll see what I can do this week.

masterT commented 6 years ago

Awesome 👍😊

mrdavemorgan commented 6 years ago

The page format has changed a lot since I last touched it, so it will take a bit of work to get it working again.

abetusk commented 5 years ago

I would also like this feature. @mrdavemorgan any chance on sharing what you have so far?

pawling11 commented 4 years ago

Hi @masterT I'd like to take up this feature.

masterT commented 4 years ago

Hi, that would be nice! 😃 I think it has been forgotten.

pawling11 commented 4 years ago

Great! I spent some time looking through the code the other night. I'll continue to do this in my spare time, but I'll check back in if i have questions or when I'm ready to open a PR!