search

masterT / bandcamp-scraper

A scraper for https://bandcamp.com
MIT License
194 stars 35 forks source link

Fix issue 35 #64

Closed idbentley closed 2 years ago

idbentley commented 2 years ago

I took a stab at solving #35.

Pretty easy to get the album and artist names, but for some reason the value of the a tag's href attribute is being loaded using javascript after the document is loaded.

So, instead I parsed the data on the #pagedata element to get not only the track title and artist name but also the artist and the album urls.

This implementation is fragile, so I added a test to match your others.

Best, Ian

masterT commented 2 years ago

Thanks for the PR 🙏🏻, I will review and test it this week.

masterT commented 2 years ago

Available in bandcamp-scraper@1.4.2.