search

mastercactapus / caddy2-proxyprotocol

Apache License 2.0
59 stars 11 forks source link

Consider switching to pires/go-proxyproto #3

Open emersion opened 4 years ago

emersion commented 4 years ago

Consider switching to pires/go-proxyproto, which has more features than your package.

Don't get me wrong, I don't dislike your package or find it low quality. It's just that pires/go-proxyproto already has a lot more features implemented and has more users (so less potential bugs).

I'd like to add more features to this Caddy plugin (e.g. TLVs). I've already took some time to improve pires/go-proxyproto, I'd prefer to avoid having to re-implement everything in mastercactapus/proxyprotocol. Would you welcome a patch that switches over to pires/go-proxyproto?

Thanks.

mholt commented 1 year ago

@mastercactapus I just wanted to bring up a discussion here, to see what your thoughts are. PROXY protocol support is ambitious and you've been valiantly providing it for years through your library, which the Caddy project has benefited from greatly. So, thank you for that.

We are starting to get requests for additional features and patches that I imagine would be a burden on your time as a volunteer maintainer.

Could we help relieve some of that burden with a patch to use go-proxyproto? I actually like the simplicity of your package better, and by all means I think you should keep maintaining it if you'd like, I just feel like go-proxyproto might be able to serve more Caddy users with less burden on you. And we'd still proudly use your package (this one) as the Caddy integration.