search

mastercake10 / CustomOreGen

A simple yet powerful, fully customizable cobblestone generator for Bukkit
GNU General Public License v3.0
11 stars 11 forks source link

[BUG] Not Working with NONFULL Waterlogged Blocks! #54

Closed MarkinhosMLP closed 1 year ago

MarkinhosMLP commented 1 year ago

https://github.com/mastercake10/CustomOreGen/assets/47507632/b02f75b1-60b1-42e1-8c5c-89e9fa9239be

MarkinhosMLP commented 1 year ago

I don't see how this a bug - water logged blocks always seem to spread water, thus triggering the block forming. I've just verified this with CustomOreGen disabled, its the same behavior.

the problem is the middle block, the in between the stone stairs and the lava, which is generating cobblestone instead of the custom blocks

mastercake10 commented 1 year ago

You're right, this is because CustomOreGen still uses the BlockFromToEvent and does some weird checks to find out if its cobblestone being generated. There is the BlockFormEvent which is much more accurate without all these checkings, but sadly it does not work for bukkit versions =< 1.12.

This means I need to incorporate both events, since 9.8% of CustomOreGen users are still using 1.8.8 :/