search

mastercoin-MSC / masterchest-wallet

Masterchest Wallet
MIT License
15 stars 13 forks source link

Failure to pay under dust to purchase on the DEx #26

Open ripper234 opened 10 years ago

ripper234 commented 10 years ago

I reserved 0.1 TMSC that were up for sell with unit price 0.00000999 BTC.

image

I then got this error:

Message from library - aborting transaction build, sanity check failed on paymentamount (under dust)

  1. Is it possible in the protocol to actually buy an asset by paying something under the dust limit?
  2. If not, then it shouldn't be possible to put it up for sale, or to reserve it.
  3. If it's possible in the protocol, the Masterchest should support it. It can round up the amount paid to the dust amount if needed.
ripper234 commented 10 years ago

Just to make it clear - the user should never be allowed to do just a part of an operation that he cannot complete.

dacoinminster commented 10 years ago

Interesting problem. I think the right thing to do in the UI is to just bump the payment up to to the dust threshold (overpay) in this case.

ripper234 commented 10 years ago

Sounds good.