search

mastercoin-MSC / mastercoin-tools

GNU Affero General Public License v3.0
9 stars 12 forks source link

prevent unicode blowups #33

Closed ghost closed 10 years ago

ghost commented 10 years ago

revert to 4f01416 because I realized the only reason we were getting that far without catching the error is because we were unsuccessfully marking this transaction.

The correct behavior was to report the error in the log and then mark it invalid, and was attempted (https://github.com/faizkhan00/mastercoin-tools/blob/031708825aff7e7b71e933bf1c74ee483cc1c430/msc_utils_parsing.py#L560) However, error() actually exits the process early making the next line (marking the transaction invalid) unreachable.

This was fixed by using 'debug' instead of 'error', and thus, 7220004 was not needed and reverted.

ghost commented 10 years ago

If it turns out consensus means this transaction should be validated, then I'm okay with re-reverting 7220004 for that case, or fixing the parse code to accept badly malformed transactions like this one.