Extract, move and test StrToInt64

mastercoin-MSC / mastercore

mastercore info

mastercoin.org

MIT License

24 stars 11 forks source link

Extract, move and test StrToInt64 #180

Closed dexX7 closed 9 years ago

dexX7 commented 9 years ago

This basically breaks down #173.

Rename strtToInt64 to StrToInt64
Moved into new files /mastercore/parse_string.h and /mastercore/parse_string.cpp
Adopted and converted @zathras-crypto's tests to BOOST tests which can be run via ./src/test/test_bitcoin
Namespace "mastercore" is used
I tend to let this sit in it's own file, because it's only used in mastercore_rpc and sendmpdialog whereby Format__MP is used in other places

Build and practical tests done.

m21 commented 9 years ago

@zathras-crypto comments please? I am kinda against creating a subdirectory for mastercore at this time Dexx: 1 = makes #including harder for QT 2 = we only have a handful of files 3 = 1 more reason I can't yet discuss

dexX7 commented 9 years ago

I see. Are you fine with "mastercore_strtoint64.h" and "mastercore_strtoint64.cpp"? The only other functions at the moment that may qualify for a combined file are the Format_MP and rounduint64, but all three have very different dependencies and scopes (at least in practise), so I tend to single purpose files. What do you think?

I'm curious now.. :p mind to send me an email to dexx@bitwatch.co re: 3? ;)

m21 commented 9 years ago

Heh sorry. Maybe: mastercore_util or mastercore_strutil?

dexX7 commented 9 years ago

Rebased, for now it's still in mastercore_parse_string. Hmm.. util is sort of generic and doesn't tell much.