mastercoin-MSC / mastercore

mastercore info
mastercoin.org
MIT License
24 stars 11 forks source link

Price everything in MSC #200

Closed dexX7 closed 9 years ago

dexX7 commented 9 years ago

This is mostly directed @zathras-crypto:

If Master Core indeed enforces trading of MSC or TMSC on one side of a meta DEx trade on the UI level, then I suggest to price everything in MSC. I tested 0.0.9-Z-UIAlpha more than once, but showing the unit price isn't really great nor useful. I suggest to show prices-in-MSC on both sides of a trade instead.

m21 commented 9 years ago

I am sure @marv-engine would be interested, maybe @dacoinminster as well. :)

dexX7 commented 9 years ago

Sure, the more opinions there are on this, the better.

zathras-crypto commented 9 years ago

Hey DexX,

Could you elaborate a bit mate?

The prices (including unit prices) should be set in MSC.

For example: BUY: Enter price per SPT & number of tokens to buy, UI will auto calculate the fixed MSC total to be spent. When listed this order is then inverted into a sell MSC for SPT.

SELL: Enter price per SPT & number of tokens to sell, UI will auto calculate the minimum MSC total to be received.

Appreciate any suggestions as always mate :)

Thanks Z

On Fri, Nov 14, 2014 at 5:49 AM, dexX7 notifications@github.com wrote:

Sure, the more opinions there are on this, the better.

— Reply to this email directly or view it on GitHub https://github.com/mastercoin-MSC/mastercore/issues/200#issuecomment-62944699 .

dexX7 commented 9 years ago

Yeah sure, here is a Paint mockup of the underlying concept:

seperation

Transformed into Master Core:

mockup

Changes:

Edit: tradeblock.com:

tradeblock

dexX7 commented 9 years ago

This seems to be material for @zathras-crypto UI integration for Omni Core: https://github.com/OmniLayer/omnicore/pull/5, and should be reevaluated over there.

zathras-crypto commented 9 years ago

FYI @dexX7 the UI does now price everything in MSC.

As you probably have seen there is a normal sell side and a 'fake' buy side (since there is no concept of a buy on MetaDEx) - the buy side is just using the inverted price so we can reflect "sell MSC for SPT" as"buy SPT with MSC" keeping it simple for the end user - this way all prices can be in MSC.

I'm not sure this should apply to RPC though (don't think it does but been many moons since I looked at MetaDEx RPC calls hehe)

On Wed, Apr 15, 2015 at 8:00 PM, dexX7 notifications@github.com wrote:

This seems to be material for @zathras-crypto https://github.com/zathras-crypto UI integration for Omni Core: OmniLayer#5 https://github.com/OmniLayer/omnicore/pull/5, and should be reevaluated over there.

— Reply to this email directly or view it on GitHub https://github.com/mastercoin-MSC/mastercore/issues/200#issuecomment-93298423 .