search

mastercoin-MSC / mastercore

mastercore info
mastercoin.org
MIT License
24 stars 11 forks source link

Don't call TXExodusFundraiser, if bRPConly #205

Closed dexX7 closed 9 years ago

dexX7 commented 9 years ago

Fix for #204.

In general, I would try to seperate actual data manipulation and passive reading.

zathras-crypto commented 9 years ago

Great catch DexX, supported PR.

Re separating state and parsing, I don't disagree it's probably just a question of priorities. Both DEx and MetaDEx work the same way, we pass them in an object and they hand it back populated before acting on it. Longer term there is no reason why those parsing/object population code bits couldn't be in separate functions, eg 1) call func to populate MetaDEx object, 2) take action on MetaDEx object - then 1) can be reused in RPC.

Let's get in this PR to clear up that bug (shouldn't affect MainNet as Exodus Fundraiser is only ongoing on TestNet), then when priorities allow perhaps look at a refactor to separate parsing and processing where prudent.

Thanks! Z

On Mon, Nov 17, 2014 at 10:13 AM, dexX7 notifications@github.com wrote:

Fix for #204 https://github.com/mastercoin-MSC/mastercore/issues/204.

In general, I would try to seperate actual data manipulation and passive

reading.

You can merge this Pull Request by running

git pull https://github.com/dexX7/bitcoin mcore-passive-parse-fix

Or view, comment on, or merge it at:

https://github.com/mastercoin-MSC/mastercore/pull/205 Commit Summary

  • Don't call TXExodusFundraiser, if bRPConly

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/mastercoin-MSC/mastercore/pull/205.