search

mastercoin-MSC / mastercore

mastercore info
mastercoin.org
MIT License
24 stars 11 forks source link

Fix alerts #211

Closed zathras-crypto closed 9 years ago

zathras-crypto commented 9 years ago

Alerts got PR'd with a broken packet check - sorry about that - here is the fix

dexX7 commented 9 years ago

Yes, I noticed this, too (thus "this isn't working" in the other thread). But maybe it's better to leave it this way or to change the whitelisted addresses, so not everyone is bothered with the "Tx 99 ..." warning.

zathras-crypto commented 9 years ago

Thanks DexX :) - the testing was still active, fixed.

zathras-crypto commented 9 years ago

So for clarity on this one...

getinfo as an RPC call is a bitcoin core call, not a master core call, and it returns bitcoin related information. Initially we simply hijacked this to drop in a version.

Now we have other info to report, I've placed in a getinfo_MP call. So just as we have done with other calls (eg bitcoin core gettransaction to master core gettransaction_MP) we have done the same with the information related to master core. The version is also now more usable for version checks per alerts.

TL:DR; Bitcoin Core info is in getinfo, Master Core info (including version) is in getinfo_MP.

Thanks :)