isTransactionTypeAllowed bypass for property = 0

mastercoin-MSC / mastercore

mastercore info

mastercoin.org

MIT License

24 stars 11 forks source link

isTransactionTypeAllowed bypass for property = 0 #226

Closed dexX7 closed 9 years ago

dexX7 commented 9 years ago

There are two cases where property = 0 is reasonable:

the property value is not validated at all
the property is indeed bitcoin and it is allowed

This is part of a split of #223.

m21 commented 9 years ago

Thanks for splitting it up Dexx. Too much risk tweaking this important function elsewhere it's in the middle of every TX validation.

dexX7 commented 9 years ago

Please note I can't split further, because the actual logic of "cancel-everything" requires the isMainEcosystemProperty() check.

dexX7 commented 9 years ago

Ah, another note: I usually run my commits against all regtests I created which I try to extend even further. Right now there are about 1250+ individual checks (estimated and based on the log for #223): https://github.com/dexX7/mastercore-rpc-tests