Adopt meta DEx reserved balances on RPC layer

dexX7 commented 9 years ago

With PR #223 all regtests pass, for the first time! ;)

Test summary:

ExodusPurchaseTest ... successful
PropertyCreationTest ... successful
P2SHTest ... successful
MetaDexPlanTest ... successful
MetaDexCancelAtPriceTest ... successful
MetaDexCancelPairAndLookupTest ... successful
MetaDexCancelEverythingInSameEcosystemTest ... successful
MetaDexCancelEverythingIgnorePropertyTest ... successful
MetaDexCancelEverythingScopeTest ... successful
DexCrossEcosystemSideEffectsTest ... successful
TraditionalDexTest ... successful

11 of 11 tests successful

https://gist.githubusercontent.com/dexX7/061c73f7d4eec0a2e767/raw/

dexX7 commented 9 years ago

Minimized and seperated from #236.

zathras-crypto commented 9 years ago

Again looks like nice simplification removing some of the code duplication. Think the 'without pending' is just a bad comment, actual code does include pending. LGTM

dexX7 commented 9 years ago

Updated to:

// confirmed balance minus unconfirmed, spent amounts

... but any alternative is welcomed. :)

dexX7 commented 9 years ago

Side note: this isn't only cosmetic, but also includes METADEX_RESERVE which was not the case earlier, resulting in incorrect balances.

zathras-crypto commented 9 years ago

Yep, assumed this was adding in the extra reserved tally that Michael split off to avoid conflict with DEx :)

Updated wording is fine mate...

mastercoin-MSC / mastercore

Adopt meta DEx reserved balances on RPC layer #233