search

mastercoin-MSC / mastercore

mastercore info
mastercoin.org
MIT License
24 stars 11 forks source link

Format: calculateFundraiser #251

Closed dexX7 closed 9 years ago

dexX7 commented 9 years ago

Mostly removes depreciated comments, no functional change.

m21 commented 9 years ago

TBD after the tag

m21 commented 9 years ago

After spending considerable time on this, and still not being 100% comfortable, I am now against accepting "non-functional changes" of such magnitude, 100+ LOC in consensus-critical code (this is the Exodus fundraiser!). Comment cleanup is a valid effort, optionally limited to a few lines.

whitj00 commented 9 years ago

NACK, no real value. Needs valid reason for commit when dealing with such code

dexX7 commented 9 years ago

Partially addressed by https://github.com/OmniLayer/omnicore/pull/17.