search

mastercoin-MSC / mastercore

mastercore info
mastercoin.org
MIT License
24 stars 11 forks source link

clang analysis #253

Closed m21 closed 9 years ago

m21 commented 9 years ago

https://github.com/mastercoin-MSC/mastercore/pull/243#issuecomment-66916919

in reference to the above is ExodusValues[0] the only concern of the tool? The function exits if marker_count is 0; marker_count is only incremented if ExodusValues[0] gets something assigned to it, so probably not an issue. I'll initialize the array anyway. Thanks!

m21 commented 9 years ago

Delivered a while back: https://github.com/mastercoin-MSC/mastercore/blob/mscore-0.0.9/src/mastercore.cpp#L1079

dexX7 commented 9 years ago

Strange, I assumed I answered here.

@m21: Yes, this was the only significant thing Clang's static analyzer found. However, there is more when running Coverty Scan, but the only tagged-as-important finding has basically no pratical relevance at this point and I submitted a fix with https://github.com/mastercoin-MSC/mastercore/pull/258 a while ago.

oob