Fix reflect kills not counting toward killstreak if original projectile owner did not use a killstreak weapon.

[CoolJosh3k]

Is your feature request related to a problem? Please describe. When scoring a reflect kill with a Pyro's airblast, for a killstreak counter to increment it requires the one who originally fired the projectile to have used a killstreak weapon. If the reflect kill happens from a projectile that was not fired from a killstreak weapon, then no killstreak credit is given.

Killstreak flamethrower reflect kill + from a non-killstreak rocket launcher = no killstreak credit for you. Killstreak flamethrower reflect kill + from a killstreak rocket launcher = yay, you scored a kill for your killstreak!

Describe the solution you'd like When a pyro scores a reflect kill using a killstreak weapon, the killstreak count should increase without reguard to the original projectile owner.

Killstreak flamethrower reflect kill + from a non-killstreak rocket launcher = yay, you scored a kill for your killstreak! Killstreak flamethrower reflect kill + from a killstreak rocket launcher = yay, you scored a kill for your killstreak!

Describe alternatives you've considered Continue to be sad that getting a high killstreak on Pyro is harder becuase of this bug.

Additional context I have asked the TF Team if they could fix this in the past. I'd hope it is a simple conditional for the weapon type, then replace the Owner with DeflectOwner.

[micwoj92]

@wgetJane wasnt that fixed?

[wgetJane]

@wgetJane wasnt that fixed?

no

[micwoj92]

Ah thanks for clarification. I thought it was resolved alongside the airblast damage bug (y)

[CoolJosh3k]

Just loaded up tr_walkway in the normal TF2 and was able to confirm that the bug does indeed still exist.

Death by fire increases killstreak. Death by reflect does not, because the bots do not use killstreak weapons to fire the rockets/grenades.

[wgetJane]

@CoolJosh3k can you test if the following increases a killstreak weapon's kill count:

• reflect kills with rockets in tf2
• reflect kills with grenades in tf2
• reflect kills with rockets in tc2
• reflect kills with grenades in tc2

[treacherousfiend]

Didn't test live (yet) but seems to still be broken in comtress, my killstreak hasn't gone up, and it didn't show up as a killstreak in the killfeed.

It might be worthwhile to test spam airblasting pyro bots against ks grenade launcher and rocket launcher? I don't have either so I can't test

[treacherousfiend]

update, in live tf2, if the other player doesn't have a ks weapon, then the pyro's ks works as expected. so its more broken in TC2 then it is in live

[Yttrium-tYcLief]

Anything broken in TC2 but working in TF2 should be (mostly) ignored. That being said, just to clarify - there are still parts of this issue that exist in both live TF2 and TC2?

[wgetJane]

@treacherousfiend can you say if the following increments a killstreak flamethrower's kill count?

• reflect kills with rockets in tf2
• reflect kills with grenades in tf2
• reflect kills with rockets in tc2
• reflect kills with grenades in tc2

this is to figure out if the issue is caused by this: https://github.com/mastercomfig/team-comtress-2/pull/17

my prediction would be:

• reflect kills with rockets in tf2: no
• reflect kills with grenades in tf2: yes
• reflect kills with rockets in tc2: no
• reflect kills with grenades in tc2: no

if this prediction is correct, then most likely the self-damage fix is related to the issue

[treacherousfiend]

hmmm, I forgot to test rockets in tf2, but grenades seem to work correctly?

I think in order to get to the bottom of this we'll need to have both players with ks weapons.

[wgetJane]

I think in order to get to the bottom of this we'll need to have both players with ks weapons.

that shouldn't be necessary for now, can you tell if the prediction is correct first

edit: confirmed that the prediction is correct, so it's related to the self-damage bug fix

[CoolJosh3k]

Did some testing and recorded the following results.

TF2 Rockets: https://youtu.be/lzyrRpt5Zyg TF2 Grenades: https://youtu.be/xK_0YhUwx14

TC2 Rockets: https://youtu.be/oucxe1W4hcw TC2 Grenades: https://youtu.be/ZTBQIDkqyTA

So yes, reflected grenades work in TF2, but got broken in TC2.

I suggest a solution for this is not undoing the other fix, but instead implementing a fix that addresses all reflect kill streak credit.

[wgetJane]

@CoolJosh3k the videos you've linked are private btw

[CoolJosh3k]

Oh, whoops. I ment to have them unlisted. Fixed that now.