Jarate/Mad Milk reskin projectiles behave like stock under certain circumstances

[Margen67]

Description

https://wiki.teamfortress.com/wiki/Self-Aware_Beauty_Mark#Bugs https://wiki.teamfortress.com/wiki/Mutated_Milk#Bugs Projectiles from the Self-Aware Beauty Mark, Festive Jarate, Mutated Milk, etc use the wrong model if you throw the projectile, and quickly switch to another weapon.

Potentially responsible code: https://github.com/mastercomfig/team-comtress-2/blob/master/game/shared/tf/tf_weapon_jar.cpp#L266-#L289

void CTFProjectile_Jar::SetCustomPipebombModel()
{
    // Check for Model Override
    int iProjectile = 0;
    CTFPlayer *pThrower = ToTFPlayer( GetThrower() );
    if ( pThrower && pThrower->GetActiveWeapon() )
    {
        CALL_ATTRIB_HOOK_INT_ON_OTHER( pThrower->GetActiveWeapon(), iProjectile, override_projectile_type );
        switch ( iProjectile )
        {
        case TF_PROJECTILE_FESTIVE_JAR :
            m_iProjectileType = iProjectile;
            SetModel( TF_WEAPON_FESTIVE_PEEJAR_MODEL );
            return;
        case TF_PROJECTILE_BREADMONSTER_JARATE:
        case TF_PROJECTILE_BREADMONSTER_MADMILK:
            m_iProjectileType = iProjectile;
            SetModel( "models/weapons/c_models/c_breadmonster/c_breadmonster.mdl" );
            return;
        }
    }

    SetModel( TF_WEAPON_PEEJAR_MODEL );
}

Checklist

• [x] None of the open or closed issues document this problem.
• [x] This is a bug, not a new idea.
• [x] This is objectively a bug, and not something that people commonly disagree on.
• [x] This bug is in the code of the game, not in the textures, sounds, or other resources.
• [x] This issue occurs on the latest vanilla TF2 update.
• [ ] This issue is listed on the Source 1 official bugtracker.
• [x] This issue occurs with DirectX level 100.
• [x] This issue occurs on the latest Team Comtress release, or the master branch.
• [x] This issue occurs when using no custom content.
• [x] This issue occurs when using start_tf2.bat (or start_server.bat) with no custom launch options.
• [x] This issue occurs when using a listen server (using the map command ingame).
• [x] This issue occurs when using a dedicated server.
• [ ] This bug is in the internal procedures or tooling (e.g. the build process).

Reproduction

1. Throw weapon
2. Switch to another weapon quickly
3. The projectile should have the model that the reskin is based off of (e.g. Jarate/Mad Milk)

Screenshots

Setup Details

• Server or client:
• Operating system:
• Team Comtress version:
• Custom content:
• Launch options:
• Graphics driver:
• DirectX level:

Performance Details

• GPU model:
• CPU model:
• RAM amount:
• TF2 installed on:
• TC2 installed on:
• TC2 installation method:

[Margen67]

Another note: If you throw a projectile close enough to an enemy, it can cause it to behave like stock (no breadmonster on head)