remove "when weapon is active" from pretty boy's pocket pistol stat description

ghost commented 3 years ago

Description

the "when weapon is active" part from the pretty boy pocket pistol's stats was left there from an earlier version which negated fall damage while weapon is active. none of the stats are affecting the player whether the weapon is active or not with this version, so it should be removed to avoid confusion.

Checklist

[x] None of the open or closed issues document this idea.
[x] This is a new idea, not a bug.
[x] This idea does not seriously affect game balance.
[x] This is obviously an improvement, not something that people commonly disagree on.
[x] This is not an idea for new game content (e.g. new weapons, maps, sounds).

[x] This idea is for the code of the game, not for textures, sounds, or other resources.
[ ] This idea has been implemented in vanilla TF2.
[ ] There is proof that this idea is well liked (e.g. a history of use of a similar mod in a competitive league).
[ ] This idea has been implemented in a mod.
[ ] This feature has existed in the vanilla game but was removed.
[ ] This idea is for internal procedures or tooling (e.g. improving the build process, supporting new systems).

Screenshots

TC2 screenshot: 20201111121725_1 TF2 screenshot: 20201111121825_1

Alternatives

MeDerpWasTaken commented 3 years ago

Isn't this only fixable by valve?

agrastiOs commented 3 years ago

@MeDerpWasTaken No.

MeDerpWasTaken commented 3 years ago

@MeDerpWasTaken No.

can't we not edit the schematics?

agrastiOs commented 3 years ago

@MeDerpWasTaken No.

can't we not edit the schematics?

that's correct that we are currently using the production item schema, however, mastercoms has mentioned that item schema issues aren't really out of scope, so we could possibly have a solution to implement item schema fixes in the future.

The item schema is very editable. Live TF2 has encrypted signature protection for it, however, which does not allow for any changes. However, before Valve implemented this type of protection, people could easily test item schema mods.

agrastiOs commented 3 years ago

@shanepm Maybe. It could be potentially be updated like we already do with localization files.

mastercomfig / tf2-patches