mastercomfig / tf2-patches

Team Fortress 2, but with a lot of fixes, QoL improvements and performance optimizations!
Other
218 stars 27 forks source link

Make votekick immediately succeed if proposed player manually disconnects #519

Open lempamo opened 3 years ago

lempamo commented 3 years ago

Description

This issue pertains to the current bot crisis in vanilla TF2, where certain cheating bots evade votekicks by disconnecting themselves from the server (by way of the disconnect console command) before the votekick completes, then simply rejoining a short time later. This can also be exploited by malicious human players who want to evade votekicks. Adding some code to automatically mark the proposed player as "banned" if they disconnect before the votekick completes would solve this issue.

Checklist

Screenshots

Alternatives

MeDerpWasTaken commented 3 years ago

this already exists...

qabRieL99 commented 3 years ago

I thought if the player disconnects before voting is completed the notification shows that it failed. Am I wrong?

ghost commented 3 years ago

@qabRieL99 pretty sure you're not, bots do not get banned when they get votekicked and they disconnect before votekick ends(also votekick is broken in mvm, it does not ban players)

MeDerpWasTaken commented 3 years ago

image

agrastiOs commented 3 years ago

AFAIK the vote does fail and the bot does not get banned, but only if they actually leave the server and don't use the 'disconnect' command.

lempamo commented 3 years ago

ah, sorry bout me being slightly mistaken then