mastercomfig / tf2-patches

Team Fortress 2, but with a lot of fixes, QoL improvements and performance optimizations!
Other
221 stars 27 forks source link

Correctly copy paste the right glow fade code for the Demoman's charge #613

Closed sticks-stuff closed 2 years ago

sticks-stuff commented 2 years ago

I noticed this when digging through the crit proxy for something else, and I figured I could submit a fix for it.

Implementation

The Demoman's charge glow is supposed to fade in and out, however it only fades out when cancelled through a melee attack. This can be fixed by simply copypasting the code from the melee attack fade out to the other part of the function

Screenshots

https://twitter.com/stick_twt/status/1472464099845963777

Checklist

Testing Checklist

Client Server Version
Windows N/A N/A N/A
Linux N/A N/A N/A
Mac OS N/A N/A N/A

Caveats

Probably nothing, its barely noticeable as is

Alternatives

Could probably reformat the maths to make it last slightly longer, but this is probably what Valve intended

mastercoms commented 2 years ago

I'm not sure if this is intentional or not, so I'm going to stay on the safe side and not accept this PR.