search

mastercoms / SlackMC

Link Slack to Minecraft!
MIT License
62 stars 11 forks source link

Incoming commands #8

Closed david50407 closed 9 years ago

david50407 commented 9 years ago

Hey there, I implement the Slack outgoing webhook server. And this PR is based on #7 I send.

mastercoms commented 9 years ago

Thank you a lot for this. Looks good with a quick glance, I am going to change a bit of the code and review it more over this weekend. Again, THANK YOU.

mastercoms commented 9 years ago

Could you explain your reasoning for using jetty? Not disagreeing with you, just want to see why you chose it and if we can discuss alternatives to make sure we include the best option for Slack.

And preferably, could you somehow remove the matching commands precisely commit from this and rebase it to the current master branch? If not, don't worry, I will work it out myself.

mastercoms commented 9 years ago

Alright, I merged this, just to mark progress but this pull request isn't done yet because we're going to have to change some stuff.

mastercoms commented 9 years ago

I will be rewriting this based on your contributions. Thanks!

david50407 commented 9 years ago

Dynmap also use jetty so I think it's ok for bukkit plugins.

mastercoms commented 9 years ago

Ok.