search

masterking32 / MasterHamsterKombatBot

Master Hamster Kombat Bot is a Python-based automation tool specifically designed for the game Hamster Kombat. This bot is capable of performing all in-game tasks, including auto-tapping, cipher tasks, and purchasing the best cards on your behalf. It's a free and fully automated farming bot that enhances your Hamster Kombat gaming experience.
https://github.com/masterking32/MasterCryptoFarmBot
Apache License 2.0
281 stars 90 forks source link

Updating logging code to what @Fy0urM suggested & Fix grammar & Remove Clone Army #211

Closed tboy1337 closed 2 months ago

tboy1337 commented 2 months ago

https://github.com/masterking32/MasterHamsterKombatBot/discussions/147

masterking32 commented 2 months ago

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

Pawansingh333 commented 2 months ago

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

yes you are right

tboy1337 commented 2 months ago

Why do we need to save logs in a file when we already have a Telegram log? The Telegram log isn't easily usable for everyone.

I dont use telegram and would prefer local logs and since there is already code in main.py for local logging which doesnt work it makes sense to fix it.

Fy0urM commented 2 months ago

an attempt to push logging into a file?))) you can make changes to the file yourself, but it will have to be done every time the bot is updated, not very convenient. i have half the script in modifications))

tboy1337 commented 2 months ago

output.log still has ANSI escape codes but at least its producing a .log file.

tboy1337 commented 2 months ago

tested fully working, thanks @Fy0urM

tboy1337 commented 2 months ago

Logging code now working in main, grammar fixed in README and Clone Army removed from promogames, please merge @masterking32.

masterking32 commented 2 months ago

Logging code now working in main, grammar fixed in README and Clone Army removed from promogames, please merge @masterking32.

You need to create a separate PR for each feature you add. Please don't include all of them in a single pull request, as it makes it difficult to select or merge individual features. Additionally, I don't believe everyone needs a log file. For some, including myself, it could result in a large, unnecessary file. The current log system is intended for display purposes only, so it's not essential for everyone. For other features, please submit separate PRs. Thanks.