search

masterking32 / MasterHamsterKombatBot

Master Hamster Kombat Bot is a Python-based automation tool specifically designed for the game Hamster Kombat. This bot is capable of performing all in-game tasks, including auto-tapping, cipher tasks, and purchasing the best cards on your behalf. It's a free and fully automated farming bot that enhances your Hamster Kombat gaming experience.
https://masterking32.com
Apache License 2.0
266 stars 87 forks source link

Clone Army Game Removal #231

Closed tboy1337 closed 2 weeks ago

tboy1337 commented 2 weeks ago

I hope there wont be a problem because of this hk_admins_removing_clone_army_game. If the bot keeps generating and claiming keys when the game isnt available that might cause issues.

Fy0urM commented 2 weeks ago

the bot generates keys only for games it received from the server, locally the bot stores only settings for requests. it goes through the array received from the server and if there is a corresponding id in the local settings it tries to generate a key, if the id received from the server is not found in the local settings the bot gives a message that an unknown game has been found, and if there is no game in the server response the bot will not go through it and therefore will not even try to generate a key. i checked the response from the server right now, there is no remote game in it. if you study the code, you'll realize that. https://github.com/masterking32/MasterHamsterKombatBot/blob/6323c888a0e00165f1dcd1fc7d367d813be36575/main.py#L888

tboy1337 commented 2 weeks ago

the bot generates keys only for games it received from the server, locally the bot stores only settings for requests. it goes through the array received from the server and if there is a corresponding id in the local settings it tries to generate a key, if the id received from the server is not found in the local settings the bot gives a message that an unknown game has been found, and if there is no game in the server response the bot will not go through it and therefore will not even try to generate a key. i checked the response from the server right now, there is no remote game in it. if you study the code, you'll realize that.

https://github.com/masterking32/MasterHamsterKombatBot/blob/6323c888a0e00165f1dcd1fc7d367d813be36575/main.py#L888

Ah I see, thanks for the information, I have removed it in https://github.com/masterking32/MasterHamsterKombatBot/pull/211

Fy0urM commented 2 weeks ago

Another question is whether we should remove the settings for this game from the bot, in case they return it with the same id but different query parameters or add another game with the same id, which is unlikely. but in this case it will lead to suspicious code generation due to incorrect query parameters. I also think that if the developers really track and “punish” those who get the keys in an unfair way, then those who use the bot from the very beginning before Vladik01-11 pointed out the code generation error are already labeled as “unscrupulous” and in principle there is no point in worrying about it.

tboy1337 commented 2 weeks ago

Another question is whether we should remove the settings for this game from the bot, in case they return it with the same id but different query parameters or add another game with the same id, which is unlikely. but in this case it will lead to suspicious code generation due to incorrect query parameters. I also think that if the developers really track and “punish” those who get the keys in an unfair way, then those who use the bot from the very beginning before Vladik01-11 pointed out the code generation error are already labeled as “unscrupulous” and in principle there is no point in worrying about it.

Imo it makes sense to remove it, if they add another game it's easy to get the ID/information about it.

tboy1337 commented 2 weeks ago

Issue was fixed in https://github.com/masterking32/MasterHamsterKombatBot/pull/232.