masterking32 / WoWSimpleRegistration

Simple Registration page for TrinityCore/AzerothCore/AshamaneCore/CMangos
https://masterking32.com
GNU General Public License v3.0
265 stars 217 forks source link

Creating passwords do not work properly #57

Closed Mr-Deadbeat closed 10 months ago

Mr-Deadbeat commented 3 years ago

Describe the bug when creating a test account for one of my test runs on your registration application i added the account but the password got rejected does it count the max allowable password lengths that Wrath of the lich king client supports think it was 16 characters

also does it support extended Ascii just wondering since i used Keepassxc to create the password had to fiddle with the settings to find a working password with a complicated enough password for my standards ;) mixed special characters, numbers and so on for maximum entropy

To Reproduce Steps to reproduce the behavior:

  1. create account name
  2. create the password test the most advanced password option from keepassxc "creates utter gibberish" for maximum entropy
  3. click on create account
  4. and it will give you error for failed creation of account not sure if the server core itself does not support advanced passwords or if it's some oversight on your part either way thought i might give you a heads up on this issue otherwise things work smoothly :) great work

btw server is not public it's just for my own use on my local network might open it up at a later date for friends and family

Expected behavior created account without issues

Screenshots have none

Desktop (please complete the following information):

Additional context nothing more to add other than keep up the good work :)

masterking32 commented 3 years ago

Actually, On the website, you can use any character for the password, but wow client cannot support everything. The best way to secure the accounts is using 2fa.

Mr-Deadbeat commented 3 years ago

Actually, On the website, you can use any character for the password, but wow client cannot support everything. The best way to secure the accounts is using 2fa.

yes i know but need to setup a web server to support 2fa which i have none atm ;)

the error i referred to during account creation was on the web server after everything was filled in including password i got the error message that in turn got me thinking maybe there are some character combos that are not taken into account ? as a test i created the same password trough the remote admin console and it accepted it so not sure what might be going on

just makes it a bit tedious to do things all over again if the password does get rejected ;)

masterking32 commented 3 years ago

Hey, We didn't add any checks for password characters! Check this there is just a password length check. But for username you need follow this pattern 0-9A-Z-_ Maybe something is wrong with your web server.

Mr-Deadbeat commented 3 years ago

Hey, We didn't add any checks for password characters! Check this there is just a password length check. But for username you need follow this pattern 0-9A-Z-_ Maybe something is wrong with your web server.

hmm going to check it later today but the server is nginx serving simple registration nothing changed except for the configs to suite my setup over here i'll take a deeper dive and check out if i can find out where the issue is

just tested it now with 16 character length and i got "Password length is not valid." ? although i used special characters in the mix wonder if it borks on that

keepassxc creates total jibberish passwords and i think that might be the problem most of the time it creates the password with characters outside of the valid range that simple registration supports so therein lies the problem using this password tool for all my passwords https://github.com/keepassxreboot/keepassxc the passwords it generates are very hard to brute force

forgot to mention i created around 10 passwords with different lengths and it borks on them all using a simple easy to hack password like test1234 and it passes so might be a good idea to add more sophisticated character combinations to the mix for account safety ;)