search

mastermoo / react-native-action-button

customizable multi-action-button component for react-native
MIT License
2.52k stars 569 forks source link

Set useNativeDriver to false explicitly in animation and reset #341

Open blindibrasil opened 4 years ago

blindibrasil commented 4 years ago

339 - Solution:

I believe that the proposal submitted earlier does not fully solve the problem presented in version 0.62 of the RN. Because it is necessary to insert useNativeDriver in the function that resets the action. https://reactnative.dev/blog/2017/02/14/using-native-driver-for-animated#how-do-i-use-this-in-my-app

sam1463 commented 4 years ago

If you wanted to, I imagine you could even add an optional prop for ActionButton of useNativeDriver, which would default to false. And then use that value in the two spots you changed, rather than a hard-coded false. Idk if there are cases where people would want it to be true for this component, but just a thought.

blindibrasil commented 4 years ago

@mastermoo or @sibelius Could you verify and merge the correction of this error?