search

mastermoo / react-native-action-button

customizable multi-action-button component for react-native
MIT License
2.52k stars 569 forks source link

add explicitly - useNativeDriver: false #342

Closed omerman closed 4 years ago

omerman commented 4 years ago

I have seen others proposing this PR.. The difference is that my commit covers all of the places that uses an animation and lacks useNativeDriver.

Closing in favour of #349

dahveed-rb commented 4 years ago

@mastermoo bump

gregfenton commented 4 years ago

@omerman - What is the onBackdropPress for? I don't see any description for it with the checkins.

omerman commented 4 years ago

oops, its actually not related to this, I added it as part of my usecase, I wanted to explicitly change a state once someone clicks the backdrop, so I added it. It is something that I think should be added as well, as a feature, cause by default it calls reset but sometimes I want to change state from my end(the consumer of the library) so onBackdropPress should provide me with more control so I can do it.

omerman commented 4 years ago

As you can see, opened a different PR containing only the useNative stuff

lukemcgregor commented 4 years ago

Nah I just proposed some changes and forked you so I had a branch to use in the meantime

omerman commented 4 years ago

Ok great, I havent noticed. so if my new PR is also not required, you are welcome to close it.