search

mastermoo / react-native-action-button

customizable multi-action-button component for react-native
MIT License
2.52k stars 570 forks source link

Move data fetching code or side effects to componentDidUpdate. #344

Open bernardnongpoh opened 4 years ago

bernardnongpoh commented 4 years ago

Warning in the console: componentWillReceiveProps has been renamed and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

yerba-mate commented 4 years ago

Yeah... Looks like it was fixed 4 months ago but never released? If you look in the ActionButton.js, you can see that the code has been updated to useEffect, but if you look at the installed version in node_modules the "componentWillReceiveProps" is still there.

Hopefully someone notices eventually.

gregfenton commented 4 years ago

There hasn't been a release since 2018??

Are people just cloning and using this code directly in their own projects?

ytr0 commented 4 years ago

Can someone tell me how to fix this? Is there a fixed version of ActionButton.js somewhere?

yerba-mate commented 4 years ago

So yeah the only way I "fixed" the problem was to clone the existing code, which contains the fix, and use it as a component. There is someone out there doing the pull-requests/fixes but no one doing the builds.

ytr0 commented 4 years ago

Ah, now I see. Thank you. I hope the maintainer is still alive.