search

mastermoo / react-native-action-button

customizable multi-action-button component for react-native
MIT License
2.52k stars 569 forks source link

Crashes React Native 0.69.x #374

Open Nantris opened 2 years ago

Nantris commented 2 years ago

The line that fails is buttonTextStyle: Text.propTypes.style,

@mastermoo, would you be open to accepting a PR for this issue? I would make one, but I don't want to bother if there's no chance of acceptance.

LucasPMM commented 2 years ago

It's not working on expo v46, I think it's related.

Nantris commented 2 years ago

@LucasPMM you can use patch-package to disable that line. It's not Expo, but rather the new version of React Native: https://github.com/facebook/react-native/issues/33557

I found it basically impossible to upgrade without relying on patch-package.

I'd still be open to submitting a PR to fix this, but if @mastermoo isn't around to accept it, then meh.

approached commented 1 year ago

I have the same error with 70.x version. You can solve the error with only one line. However, it does not bring to make a new pull request. Because the maintainer does not respond anyway.

It is time to make a new package with the whole pull request!

Does anyone want to participate in the team on the package?

Nantris commented 1 year ago

@approached that's probably a good idea since componentWillReceiveProps is used in the code, which is long deprecated. Replacing that single function, plus fixing this issue and #339 would bring everything up to speed I think.

Shin1122 commented 1 year ago

same problem on 70.x, waiting for the solution ~

Nantris commented 1 year ago

@Shin1122 this repo is unmaintained. Use patch-package to comment out lines that contain references to Text.propTypes or ViewPropTypes