clangcl crash for row_win.cc

[GoogleCodeExporter]

Revert of chromium DEPS roll to r1470 (patchset #1 id:1 of
https://codereview.chromium.org/1295403004/ )

Reason for revert:
https://chromium.googlesource.com/libyuv/libyuv/+/94d4269936472587ca201df4287b6c
5a22dc85ff
makes clang-cl crash:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/2679/steps/c
ompile/logs/stdio

Original issue's description:
libyuv roll to r1470 from r1466

BUG=chromium:469376,chromium:267773

Original issue reported on code.google.com by fbarch...@chromium.org on 24 Aug 2015 at 6:32

[GoogleCodeExporter]

The issue is with structure fields using in YUV

set GYP_DEFINES=buildtype=Dev clang=1 target_arch=ia32 libyuv_enable_svn=1
python gyp_libyuv -fninja -Gconfig=Debug libyuv_test.gyp

ninja -C out\Debug

ninja: Entering directory `out\Debug'
[145/153] CXX obj\source\libyuv.row_win.obj
FAILED: ninja -t msvc -e environment.x86 -- 
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo 
/showIncludes /FC @obj\source\libyuv.row_wi
n.obj.rsp /c ..\..\source\row_win.cc /Foobj\source\libyuv.row_win.obj 
/Fdobj\libyuv.cc.pdb
Assertion failed: End.getPointer() <= EndPtr && "frontend claimed part of a 
token?", file 
D:\src\chromium\src\third_party\llvm\lib\Target\X86\AsmParser\X86AsmPa
rser.cpp, line 1380
0x00000001407C5566 (0x0000000000000016 0x000007FE47052C2D 0x0000000000000000 
0x0000000077CB8FDA)
0x000007FEEC2CEE1D (0x000007FE00000001 0x0000000000000000 0x0000000142464164 
0x0000000000000058), raise() + 0x1E9 bytes(s)
0x000007FEEC2D4A14 (0x000007FEEC33C4D0 0x0000000142464164 0x0000000142464286 
0x0000000142464164), abort() + 0x18 bytes(s)
0x000007FEEC2D5D5F (0x6D7920B500340023 0x0000000000BC0430 0x0000000000AC0298 
0x0000000000A290E8), _wassert() + 0x94F bytes(s)
0x000000014009823E (0x0000000000BB7D60 0x00000000032F8F10 0x0000000003475DC0 
0x0000000003475DC8)
0x0000000140097493 (0x0000000000A2A620 0x0000000141EF9D19 0x0000000142461BAC 
0x00000001400931F5)
0x0000000140094F64 (0x0000000000A29738 0x0000000000A29755 0x0000000000000001 
0x4C4D534100000001)
0x000000014008DE81 (0x0000000000000082 0x0000000003357160 0x0000000000020000 
0x0000000000000000)
0x0000000140680007 (0x0000000000000020 0x0000000000000020 0x0000000000AC02A8 
0x0000000077CDF9B8)
0x000000014067AE16 (0x0000000000000000 0x0000000000000000 0x00000000033BFE28 
0x0000000141440ABF)
0x000000014123E189 (0x0000000000000000 0x0000000000A2B720 0x0000000000A2B748 
0x0000000000A2B7A0)
0x000000014123F797 (0x000000000000003B 0x0000000000B83F70 0x0000000000B86160 
0x0000000141CAECC3)
0x000000014120CF4E (0x0000000000B83F60 0x0000000000A2C108 0x0000000000A2C600 
0x0000000141CB3289)
0x000000014120C164 (0x00000000034A5F30 0x0000000141A86DB7 0x0000000000000000 
0x0000000000A2BE47)
0x00000001412146AF (0x0000000000000000 0x0000000000000000 0x0000000000000000 
0x0000000000000037)
0x0000000141214F78 (0x0000000000B86160 0x00000001409214BD 0x0000000200000001 
0x0000000141CBCC74)
0x000000014119F2F7 (0x0000000000000004 0x0000000000D600B1 0x0000000000B83F70 
0x0000000141CBB911)
0x00000001411F50B7 (0x0000000000D50348 0x0000000000000006 0x0000000000B86100 
0x0000000000000006)
0x000000014119E6B2 (0x0000000000B86160 0x0000000141CAECC3 0x0000000100000348 
0x0000000000000000)
0x000000014119E081 (0x0000000000000003 0x0000000000B83F70 0x0000000000AFBE00 
0x0000000000B84210)
0x000000014119C94F (0x000000000000000F 0x0000000140947400 0x0000000000B8FBB0 
0x0000000000000000)
0x00000001411B8A36 (0x0000000000B57FF0 0x0000000000AEF540 0x0000000000000000 
0x0000000140946DAE)
0x000000014119E683 (0x0000000000000003 0x0000000141CB022A 0x0000000000000000 
0x0000000000A2D528)
0x000000014119E081 (0x00000000032865C0 0x0000000000B8F9F0 0x000000000327B148 
0x00000001413E2CEC)
0x000000014119C94F (0x0000000000000000 0x0000000000000000 0x000002870000027D 
0x0000000000BBD610)
0x00000001411B85D9 (0x000000000000000F 0x0000000000B83F00 0x0000000000A2D848 
0x0000000000000000)
0x00000001411B7A4D (0x0000000141E79656 0x00000000FFFFFFFF 0x0000000000AFBEA0 
0x0000000141D0BF18)
0x00000001411EFAE7 (0x000000000331FD60 0x0000000000B8FBB0 0x0000000141E79F00 
0x0000000000AEF540)
0x000000014119D206 (0x0000000000AEF540 0x0000000142901558 0x000000000331FCC8 
0x0000000000AE4C20)
0x000000014119C095 (0x0000000000AE47F0 0x0000000000AF11D8 0x0000000000000000 
0x0000000000000000)
0x0000000141198CC6 (0x0000000000ADB480 0x0000000000AF8640 0x0000000000000001 
0x0000000000000000)
0x0000000140C462EE (0x0000000000AF11D8 0x0000000000000001 0x00000001426104FF 
0x0000000000000017)
0x0000000140C3723D (0x000000000000000C 0x00000001429C3AB0 0x0000000000000001 
0x000007FEEC2C6A57)
0x0000000140CB86FB (0x0000000000AEEE80 0x0000000000000101 0x00000001429ADFE8 
0x0000000000A2F150)
0x000000013F6368D6 (0x0000000000000101 0x000000000000000F 0x0000000000AC0158 
0x00000000000000D4)
0x000000013F6349A4 (0x0000000000000000 0x0000000000000000 0x0000000000000000 
0x0000000000000000)
0x0000000141E76BA7 (0x0000000000000000 0x0000000000000000 0x0000000000000000 
0x0000000000000000)
0x0000000077B85A4D (0x0000000000000000 0x0000000000000000 0x0000000000000000 
0x0000000000000000), BaseThreadInitThunk() + 0xD bytes(s)
0x0000000077CBB831 (0x0000000000000000 0x0000000000000000 0x0000000000000000 
0x0000000000000000), RtlUserThreadStart() + 0x21 bytes(s)
clang-cl.exe: error: clang frontend command failed due to signal (use -v to see 
invocation)
clang version 3.8.0 (trunk 243039)
Target: i386-pc-windows-msvc
Thread model: posix
clang-cl.exe: note: diagnostic msg: PLEASE submit a bug report to 
http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and 
associated run
 script.
clang-cl.exe: note: diagnostic msg:
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-cl.exe: note: diagnostic msg: d:\src\tmp\row_win-2cab7d.sh
clang-cl.exe: note: diagnostic msg:

********************
[145/153] CXX obj\unit_test\libyuv_unittest.convert_test.obj
ninja: build stopped: subcommand failed.

Original comment by fbarch...@chromium.org on 25 Aug 2015 at 5:48

• Changed state: Accepted

[GoogleCodeExporter]

Work around is to use offsets.  r1474
Followup to switch structures to a pointer to structures that can be passed to 
common code.

Original comment by fbarch...@chromium.org on 26 Aug 2015 at 10:15

• Changed state: Fixed